[Backport 1.6.latest] Partial parsing issue when adding groups and updating models at the same time #8839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Now that we've released v1.7, and v1.6 has moved to "critical support," we tend to be more judicious about which bug fixes we'll backport for v1.6.x patches. @graciegoheen What's your preference with this one? |
|
@jtcohen6 Any risk in backporting? It's not a critical fix (workaround would just be to do a --no-partial-parse), but would come up anytime folks add a new group and set models to private in that group for the first time |
martynydbt
approved these changes
Nov 15, 2023
martynydbt
suggested changes
Nov 15, 2023
martynydbt
approved these changes
Nov 16, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport a7e2d9b from #8817.